Repository navigation
ci: pin the Codex review job to ubuntu-24.04 - #228
Merged
Merged
Conversation
ubuntu-latest now resolves to the ubuntu-26.04 image for this job, and codex-action's drop-sudo step fails there with "Could not restrict access to /run/dbus/system_bus_socket", so Codex never starts and the check fails on every pull request. This is upstream issue openai/codex-action#188 (fix proposed in #191). Pin the job to ubuntu-24.04 until a codex-action release ships the fix.
Codex Automated Code ReviewCode Review SummaryPR: Pins the Codex review job to Ubuntu 24.04 to avoid the documented P0 - Critical Issues (Must Fix)None found P1 - High Priority Issues (Should Fix)None found P2 - Medium Priority Issues (Consider Fixing)None found P3 - Low Priority Issues (Optional)None found Positive Observations
Reviewed the complete diff and surrounding workflow. GitHub-hosted execution was not available locally. Automated review by OpenAI Codex |
 [Low impact] The PR appears safe to merge.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Codex Code Review check fails on every pull request before Codex starts (seen on #226 and #227):
The job runs on
ubuntu-latest, which now resolves to theubuntu-26.04image (run 42826956843: Ubuntu 26.04.1, image version 20261101.186.1). codex-action's drop-sudo step fails on that image; this is upstream issue openai/codex-action#188, with a fix proposed in openai/codex-action#191 and not yet released. Other projects affected by it pin the job toubuntu-24.04.Change
.github/workflows/codex-review.yml:runs-on: ubuntu-24.04for the Codex job, with a comment naming the upstream issue and when to return toubuntu-latest.Verification
The workflow triggers on
pull_request, so this PR's own Codex Code Review run uses the pinned runner and shows whether the fix works.